Skip to content

In lifecycle tests, dismiss the Verify toast if it appears#252

Merged
andybalaam merged 6 commits into
mainfrom
dismiss-verify-toast
Apr 14, 2026
Merged

In lifecycle tests, dismiss the Verify toast if it appears#252
andybalaam merged 6 commits into
mainfrom
dismiss-verify-toast

Conversation

@andybalaam

@andybalaam andybalaam commented Apr 10, 2026

Copy link
Copy Markdown
Member

This is an attempt at fixing the playwright test errors we are seeing in the downstream tests for element-hq/element-web#32891

This is my first PR in this repo and I may well have done everything wrong - please let me know if so!

Please ignore commits and look at the full diff. I will squash when we merge.

@andybalaam
andybalaam force-pushed the dismiss-verify-toast branch from 94ec0a9 to f94b456 Compare April 10, 2026 12:17
@andybalaam
andybalaam marked this pull request as ready for review April 10, 2026 13:36
@andybalaam
andybalaam requested a review from a team as a code owner April 10, 2026 13:36
Comment thread playwright/element-web-test.ts Outdated
@andybalaam
andybalaam merged commit 811f769 into main Apr 14, 2026
17 checks passed
@andybalaam
andybalaam deleted the dismiss-verify-toast branch April 14, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants